feat: itemsControl property of Side Navigation #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2673 +/- ##
==========================================
+ Coverage 95.85% 95.93% +0.08%
==========================================
Files 744 746 +2
Lines 20581 20679 +98
Branches 7024 7043 +19
==========================================
+ Hits 19727 19839 +112
- Misses 798 832 +34
+ Partials 56 8 -48 ☔ View full report in Codecov by Sentry. |
pan-kot
reviewed
Sep 6, 2024
Manzurka
changed the title
|
Manzurka
had a problem deploying
to
dev-pages
GitHub Actions
Failure
Manzurka
had a problem deploying
to
dev-pages
GitHub Actions
Failure
pan-kot
approved these changes
Sep 13, 2024
Merged
via the queue into
cloudscape-design:main
with commit Sep 13, 2024
3b871f2
31 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Items Control property allows customers to define the component of their chose to be added to a slot below the header and above the items of Side Navigation Panel. For example, customers can pass Select or Multi-select components with custom attribute values (ex. options, selectedOption, triggerVariant, label, loadingText). Use case: This allows customers to define a callback function onChange event of the component, for example, to allow users filter out navigation menu items.
Related links
AWSUI-54774
API Proposal ID bG8cAsCSosVm
How has this been tested?
Unit tests, snapshot test, integ test have been added.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction. n/aTesting
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.